Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ampersand ('&') is not part of the Punctuator production #573

Closed
CornedBee opened this issue Mar 28, 2019 · 3 comments · Fixed by #574
Closed

Ampersand ('&') is not part of the Punctuator production #573

CornedBee opened this issue Mar 28, 2019 · 3 comments · Fixed by #574

Comments

@CornedBee
Copy link
Contributor

The Punctuator lexical token does not contain the ampersand '&'. However, this symbol is used in the ImplementsInterfaces production later on.

This appears to be an oversight. '&' should be added to the Punctuator production.
@IvanGoncharov IvanGoncharov added the ✏️ Editorial PR is non-normative or does not influence implementation label Mar 28, 2019
@IvanGoncharov
Copy link
Member

@CornedBee You're absolutely right 👍
Do you want to work on PR?

CornedBee pushed a commit to CornedBee/graphql-spec that referenced this issue Mar 28, 2019
Add missing '&' to Punctuator production (graphql#573)
99ba219
@CornedBee CornedBee mentioned this issue Mar 28, 2019
Merged
@CornedBee
Copy link
Contributor Author

I created a PR.

@IvanGoncharov IvanGoncharov removed the ✏️ Editorial PR is non-normative or does not influence implementation label Mar 28, 2019
@IvanGoncharov
Copy link
Member

@CornedBee Thanks 👍
I'm closing this issue since change is tracked in #574

leebyron pushed a commit that referenced this issue Jul 3, 2019
@CornedBee @leebyron
Add missing '&' to Punctuator production (#573) (#574)
51337d6 
* Add missing '&' to Punctuator production (#573)

* Order by code point value

* Order by code point value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing '&' to Punctuator production (graphql#573) CornedBee/graphql-spec
2 participants
@CornedBee @IvanGoncharov