Schema View Comments Fixes #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
December 3, 2018 10:42
…, save button saves disabled comments
Fix for additional line-breaks after each item
Schema will now default to true for commentsDisabled and commentDescription properties
|
@rajinwonderland Thanks for your PR! It will be in next release. 🚀 |
cgxxv
pushed a commit
to cgxxv/graphql-playground
that referenced
this pull request
Mar 25, 2022
* Merged from sdl-tabs https://github.com/Novvum/graphql-playground.git * Added and integrated setting's key for 'schema.disableComments' * Merged changes from disableComments branch * Fixes and style changes matching @kuldar's design specs. Details on graphql#897 comments * Still not able to cmd+save settings. Might be a deeper issue. However, save button saves disabled comments * Added tabWidth prop to SideTab.tsx to provide specific widths for different tabs. * Fix for Tab Spacing in collapsed state Fix for additional line-breaks after each item * Updates for using 'esc' on keydown to close tabs * Updated createSDL.tsx Schema will now default to true for commentsDisabled and commentDescription properties * Fixed Electron
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (for supporting
""" Comments """)SDLView.tsxforSDLView.tsxBackground:
The major issue was that the
printSchema()function was not converting commentsi.e
""" Some Comment"""to a description
i.e
# Some descriptionThe
addLinebreak()function was replacing the#token, not the"""token. Which is what lead to the syntax highlighting for the Codemirror component reading the comments as an invalid character.Also the cause for why the
commentsDisabledproperty may not have worked for those using the"""method of commenting on their schemas.Screenshots 📸 🖥
Changes proposed in this pull request:
Added default params to
getSDL(..., commentsDisabled: boolean = true)Added default argument of true for
printSchema(..., commentDescriptions: boolean = true)Tested on Electron & React app.
Note
I'm not sure how versioning works with the electron & react apps, but I tested this via
yarn link