Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning about uncontrolled input #851

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

rynobax
Copy link
Contributor

@rynobax rynobax commented Oct 6, 2018

A new session's name will initially be undefined, so I ensured that the value we pass to the input will always be a string. This fixes the React warning Warning: A component is changing an uncontrolled input of type undefined to be controlled that was appearing when you rename a tab.

@huv1k
Copy link
Collaborator

huv1k commented Oct 15, 2018

Thanks for your PR 🚀

@huv1k huv1k merged commit c8a7099 into graphql:master Oct 15, 2018
cgxxv pushed a commit to cgxxv/graphql-playground that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants