Add path to formatError #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While path was added to the serializable error, it was not yet added to the default formatError function. Adding this is technically breaking since it begins to expose new information from your API.
|
How does this addition to graphql-js interact with the spec RFC? Does that mean we're pretty comfortable with the RFC and I can start pointing people to this feature? |
|
Yeah I like error path, I'm excited about enshrining it in spec :) - I'd say this change is mostly incremental for graphql-js since path was already a serializable field on the error object, but now it is preserved for formatError as well. This change likely should have been made a while ago. I'd call this an experimental implementation of a near complete spec addition. |
|
Sounds good! Really excited to have this, it will make handling errors much better by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While path was added to the serializable error, it was not yet added to the default formatError function.
Adding this is technically breaking since it begins to expose new information from your API.