Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ‘GraphQL’ prefix to input object types #526

Merged
merged 3 commits into from
Oct 28, 2016

Conversation

calebmer
Copy link
Contributor

@calebmer calebmer commented Oct 23, 2016

Types with names like InputObjectConfig are inconsistent with all other type names. This makes the types awkward to import and use. This may be considered a breaking change (although I’d venture to believe very few people if any are importing this specific file to get at the types). If you’d like to mitigate breakage we could re-export aliases like so:

export type InputObjectConfig = GraphQLInputObjectTypeConfig

Types with names like `InputObjectConfig` are inconsistent with all other type names. This makes the types awkward to import and use. This may be considered a breaking change (although I’d venture to believe very few people if any are importing this specific file to get at the types). If you’d like to mitigate breakage we could re-export aliases like so:

```js
export type InputObjectConfig = GraphQLInputObjectConfig
```
@calebmer
Copy link
Contributor Author

An overview of the changes:

  • InputObjectConfig -> GraphQLInputObjectTypeConfig (like GraphQLObjectTypeConfig)
  • InputObjectFieldConfig -> GraphQLInputFieldConfig (like GraphQLFieldConfig)
  • InputObjectConfigFieldMap -> GraphQLInputFieldConfigMap (like GraphQLFieldConfigMap)
  • InputObjectField -> GraphQLInputFieldDefinition (like GraphQLFieldDefinition)
  • InputObjectFieldMap -> GraphQLInputFieldDefinitionMap (like GraphQLFieldDefinitionMap)

@leebyron
Copy link
Contributor

#seemslegit thanks!

@calebmer calebmer deleted the patch-1 branch October 28, 2016 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants