Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typescript definition for getVariableValues #2224

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Fix typescript definition for getVariableValues #2224

merged 1 commit into from
Oct 21, 2019

Conversation

ivome
Copy link
Contributor

@ivome ivome commented Oct 16, 2019

This fixes the typescript definition to match flow and prevent errors when passing a read-only array.

@IvanGoncharov IvanGoncharov merged commit 1fe12f4 into graphql:master Oct 21, 2019
@IvanGoncharov
Copy link
Member

@ivome Thanks a lot for PR 👍
At the moment we are working on 15.0.0 release so this change would be released as 15.0.0-alpha.2.
Do you need this fix to be backported in 14.x.x or you can wait for 15.0.0 release?

@ivome
Copy link
Contributor Author

ivome commented Oct 21, 2019

Thanks for merging this! I can wait for the 15.x release. I am doing the type conversions manually in my codebase for now...

@IvanGoncharov IvanGoncharov added the PR: bug fix 🐞 requires increase of "patch" version number label Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivome @IvanGoncharov