Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Number lexer lookahead restriction #2164

Merged
merged 1 commit into from
Sep 15, 2019
Merged

Conversation

leebyron
Copy link
Contributor

Implements and adds the tests described by graphql/graphql-spec#601

@leebyron leebyron added the spec RFC Implementation of a proposed change to the GraphQL specification label Sep 11, 2019
Copy link
Member

@IvanGoncharov IvanGoncharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
Also thanks for #2162 👍

@leebyron leebyron changed the base branch from lexing-greedy-rfc to master September 12, 2019 15:43
Implements and adds the tests described by graphql/graphql-spec#601
@leebyron leebyron force-pushed the number-lookahead-rfc branch from 1c5dcc9 to ee06056 Compare September 12, 2019 15:43
@IvanGoncharov IvanGoncharov added the PR: breaking change 💥 implementation requires increase of "major" version number label Sep 15, 2019
@IvanGoncharov IvanGoncharov merged commit ca1c1df into master Sep 15, 2019
@IvanGoncharov IvanGoncharov deleted the number-lookahead-rfc branch September 15, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: breaking change 💥 implementation requires increase of "major" version number spec RFC Implementation of a proposed change to the GraphQL specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants