debounce schema change events to fix codegen bugs #3647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1930fb5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
acao
force-pushed
the
debounce-schema-change-events
branch
2 times, most recently
from
ed89b00 to
7313ff7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3647 +/- ##
==========================================
+ Coverage 60.80% 60.86% +0.06%
==========================================
Files 120 120
Lines 5620 5621 +1
Branches 1489 1492 +3
==========================================
+ Hits 3417 3421 +4
+ Misses 1750 1748 -2
+ Partials 453 452 -1
|
acao
force-pushed
the
debounce-schema-change-events
branch
from
7313ff7 to
b21282e
Compare
on mass file changes, network schema is requesting schema way too frequently because the schema cache is invalidated on every schema file change to address this, we debounce the onSchemaChange event by 400ms also, fix bugs with tests, and schemaCacheTTL setting not being passed to the cache
acao
force-pushed
the
debounce-schema-change-events
branch
from
b21282e to
af3102a
Compare
|
The latest changes of this PR are available as canary in npm (based on the declared |
acao
force-pushed
the
debounce-schema-change-events
branch
2 times, most recently
from
c484615 to
4b3abcc
Compare
acao
force-pushed
the
debounce-schema-change-events
branch
from
4b3abcc to
1ef543d
Compare
acao
force-pushed
the
debounce-schema-change-events
branch
from
fd39c2c to
ae40378
Compare
TallTed
suggested changes
Jul 8, 2024
thanks @TallTed! Co-authored-by: Ted Thibodeau Jr <[email protected]>
Merged
dimaMachina
pushed a commit
to dimaMachina/graphiql
that referenced
this pull request
Jul 24, 2024
* debounce schema change events to fix codegen bugs on mass file changes, network schema is requesting schema way too frequently because the schema cache is invalidated on every schema file change to address this, we debounce the onSchemaChange event by 400ms also, fix bugs with tests, and schemaCacheTTL setting not being passed to the cache * changeset * fix: docs update * fix: upgrade extension bundlers * Apply formatting suggestions from code review thanks @TallTed! Co-authored-by: Ted Thibodeau Jr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on mass file changes, network schema is requesting schema way too frequently because the schema cache is invalidated on every schema file change
to address this, we debounce the onSchemaChange event by 400ms
also, fix bugs with tests, and schemaCacheTTL setting not being passed to the cache
This also includes an integration test to confirm schema changes over the network! 🥳
this should address #3622 properly