introduce pnpm, fix build tooling #3054

acao · 2023-02-25T20:43:36Z

I almost forgot to look at #232, which has plenty of the missing pieces to borrow from, and give credit to the author as well! For example, they have taken care of github actions/etc already

changeset-bot · 2023-02-25T20:43:39Z

⚠️ No Changeset found

Latest commit: d48208e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2023-02-26T10:13:21Z

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

dimaMachina · 2023-04-30T00:00:50Z

examples/cm6-graphql-parcel/README.md

@@ -5,5 +5,5 @@ GraphQL implementation with parcel bundler.

 ### Setup

-1. `yarn` and `yarn start` from this folder to start parcel dev mode.
-1. `yarn build` to find production ready files.
+1. `pnpm` and `pnpm start` from this folder to start parcel dev mode.


Suggested change

1. `pnpm` and `pnpm start` from this folder to start parcel dev mode.

1. `pnpm i` and `pnpm start` from this folder to start parcel dev mode.

dimaMachina · 2023-04-30T00:01:05Z

examples/graphiql-create-react-app/README.md

@@ -4,5 +4,5 @@ This example demonstrates how to transpile your own custom ES6 and typescript Gr

 ### Setup

-1. `yarn` and `yarn start` from this folder to start `react-scripts` dev server.
-1. `yarn build` from this folder to build production ready transpiled files using `react-scripts`. Find the output in `build` folder.
+1. `pnpm` and `pnpm start` from this folder to start `react-scripts` dev server.


Suggested change

1. `pnpm` and `pnpm start` from this folder to start `react-scripts` dev server.

1. `pnpm i` and `pnpm start` from this folder to start `react-scripts` dev server.

dimaMachina · 2023-04-30T00:01:34Z

examples/graphiql-parcel/README.md

@@ -5,5 +5,5 @@ implementation with parcel bundler.

 ### Setup

-1. `yarn` and `yarn start` from this folder to start parcel dev mode.
-1. `yarn build` to find production ready files.
+1. `pnpm` and `pnpm start` from this folder to start parcel dev mode.


Suggested change

1. `pnpm` and `pnpm start` from this folder to start parcel dev mode.

1. `pnpm i` and `pnpm start` from this folder to start parcel dev mode.

dimaMachina · 2023-04-30T00:02:03Z

examples/monaco-graphql-react-vite/README.md

@@ -10,4 +10,4 @@ This workspace could be used to help us prototype components & hooks for

 ## Setup

-In this directory, you can just run `yarn` and `yarn start`
+In this directory, you can just run `pnpm` and `pnpm start`


Suggested change

In this directory, you can just run `pnpm` and `pnpm start`

In this directory, you can just run `pnpm i` and `pnpm start`

dimaMachina · 2023-04-30T00:02:20Z

examples/monaco-graphql-webpack/README.md

@@ -4,7 +4,7 @@ A simple example of `monaco-graphql` using webpack 4

 ### Setup

-`yarn` and `yarn start` from this folder to start webpack dev server
+`pnpm` and `pnpm start` from this folder to start webpack dev server


Suggested change

`pnpm` and `pnpm start` from this folder to start webpack dev server

`pnpm i` and `pnpm start` from this folder to start webpack dev server

dimaMachina · 2023-04-30T00:05:04Z

packages/codemirror-graphql/package.json

@@ -35,10 +35,10 @@
    "!jest.config.js"
  ],
  "scripts": {
-    "build": "yarn build-clean && yarn build-js && yarn build-esm && yarn build-flow .",
+    "build": "yarn build-js && yarn build-esm && yarn build-flow .",


Should we use pnpm here and for other scripts in this file?

dimaMachina · 2023-04-30T00:06:09Z

packages/graphiql/.gitignore

@@ -9,7 +9,7 @@ analyzer.html
 /graphiql.*js.map
 /graphiql.*css
 /graphiql.*css.map
-example/yarn.lock
+example/pnpm.lock


Suggested change

example/pnpm.lock

example/pnpm-lock.yaml

can you tell I did a cheap bulk find replace and it's a mess ? haha

dimaMachina · 2023-04-30T00:07:28Z

packages/graphiql/package.json

    "e2e-server": "start-server-and-test 'cross-env PORT=8080 node test/e2e-server' 'http-get://localhost:8080/graphql?query={test { id }}'",
    "storybook": "start-storybook",
    "webpack": "webpack-cli --config resources/webpack.config.js"
  },
  "dependencies": {
    "@graphiql/react": "^0.16.0",
-    "@graphiql/toolkit": "^0.8.1",
+    "@graphiql/toolkit": "^0.8.0",


Suggested change

"@graphiql/toolkit": "^0.8.0",

"@graphiql/toolkit": "workspace:*",

All monorepo packages/examples should contain the above

hmmm ok, and then they are rewritten on publish? i will have to double check how this works with changesets, because currently this is automatically managed by changesets

and then they are rewritten on publish?

yes

dimaMachina · 2023-04-30T00:08:03Z

packages/graphql-language-service-cli/.npmignore

@@ -1,3 +1,3 @@
 node_modules
 src
-yarn.lock
+pnpm.lock


Suggested change

pnpm.lock

pnpm-lock.yaml

dimaMachina · 2023-04-30T00:09:17Z

packages/graphql-language-service-cli/README.md


 ```sh
-yarn global add graphql-language-service-cli
+pnpm global add graphql-language-service-cli


Suggested change

pnpm global add graphql-language-service-cli

pnpm add -g graphql-language-service-cli

dimaMachina · 2023-04-30T00:09:34Z

packages/graphql-language-service-cli/package.json

@@ -35,6 +35,7 @@
    "graphql": "^15.5.0 || ^16.0.0"
  },
  "dependencies": {
+    "@types/yargs": "^16.0.0",


Should be devdeps

dimaMachina · 2023-04-30T00:09:52Z

packages/graphql-language-service-server/.npmignore

@@ -1,3 +1,3 @@
 node_modules
 src
-yarn.lock
+pnpm.lock


Suggested change

pnpm.lock

pnpm-lock.yaml

dimaMachina · 2023-04-30T00:11:11Z

packages/graphql-language-service/src/temp-bin.ts

-    ${bright('yarn global add graphql-language-service-cli')}
+  pnpm:
+    ${bright('pnpm global remove graphql-language-service')}
+    ${bright('pnpm global add graphql-language-service-cli')}


Suggested change

${bright('pnpm global add graphql-language-service-cli')}

${bright('pnpm add -g graphql-language-service-cli')}

dimaMachina · 2023-04-30T00:11:54Z

packages/graphql-language-service/src/temp-bin.ts

-    ${bright('yarn global remove graphql-language-service')}
-    ${bright('yarn global add graphql-language-service-cli')}
+  pnpm:
+    ${bright('pnpm global remove graphql-language-service')}


Suggested change

${bright('pnpm global remove graphql-language-service')}

${bright('pnpm remove -g graphql-language-service')}

dimaMachina · 2023-04-30T00:12:52Z

packages/vscode-graphql/README.md

@@ -301,7 +301,7 @@ This plugin uses the
 [GraphQL language server](https://github.com/graphql/graphql-language-service-server)

 1.  Clone the repository - https://github.com/graphql/graphiql
-1.  `yarn`
+1.  `pnpm`


Suggested change

1. `pnpm`

1. `pnpm i`

dimaMachina · 2023-04-30T00:14:06Z

scripts/canary-release.js

@@ -29,7 +29,7 @@ const git = async (...commands) => execa('git', commands, execOpts);
 // async function preReleaseVSCode(version) {
 //   try {
 //     await execa(
-//       'yarn',
+//       'pnpm',
 //       ['workspace', `vscode-graphql`, 'run', 'release', '--pre'],


Suggested change

// ['workspace', `vscode-graphql`, 'run', 'release', '--pre'],

// ['--filter', `vscode-graphql`, 'release', '--pre'],

acao · 2023-05-02T07:22:33Z

@B2o5T if i recall, this is missing a bunch of my local commits that adds an entirely new build tool (tsup) and so much more, @B2o5T let's schedule a session to go over this later in the week? anyone else who wants to join is invited

acao · 2023-05-03T10:10:50Z

@dotansimha and @B2o5T - i have pushed the afformentioned additional commit from changes that i had left on my local git stash from february, the very helpful review comments are still relevant. tonight after work I will clean it up and I'm available for a chat or async if you have any questions!

acao · 2023-05-03T10:16:05Z

todo:

- cleanup errant find-replace changes
- rebase
- figure out tsconfig jsx recipe that prevents the need for react import
-

dimaMachina · 2023-05-03T10:59:58Z

figure out tsconfig jsx recipe that prevents the need for react import

@acao I think @thomasheyenbrock found some issues with it #3017

acao · 2023-05-03T11:00:59Z

@B2o5T indeed, this PR was created after that, and required reverting the change he made there for now, but we will figure that out!

dimaMachina · 2023-05-03T11:03:33Z

packages/graphiql-react/.gitignore

+vite.config.js
+vite.config.d.ts


can you remove also generated files vite.config.js, vite.config.d.ts from packages/graphiql-react?

acao · 2023-05-03T12:12:32Z

@B2o5T also, fwiw, feel free to push to this branch if you don't want to wait for me haha

dimaMachina · 2023-05-03T12:32:34Z

@B2o5T also, fwiw, feel free to push to this branch if you don't want to wait for me haha

@acao these files not present in your branch, but exists in main branch, you should do a rebase :)

acao · 2023-05-03T12:56:36Z

@B2o5T indeed, i will try to get to it after work, maybe around 19:00 UTC. i just wanted to push what i had during lunch break real quick for reference

acao changed the title ~~pnpm mode WIP~~ pnpm WIP Feb 25, 2023

acao force-pushed the pnpm branch from 856f755 to ecb7113 Compare February 25, 2023 20:44

pnpm mode WIP

f417211

acao force-pushed the pnpm branch 9 times, most recently from 5ac8635 to 4a2d1a6 Compare February 26, 2023 10:10

everything but that one test mock and e2e working

926f2c2

acao force-pushed the pnpm branch from 4a2d1a6 to 926f2c2 Compare February 26, 2023 10:11

build working

9f50451

acao force-pushed the pnpm branch 13 times, most recently from deb4850 to f4bcb59 Compare February 26, 2023 12:55

dimaMachina reviewed Apr 30, 2023

View reviewed changes

fix: introduce tsup, fix references

d48208e

acao marked this pull request as draft May 3, 2023 10:13

dimaMachina reviewed May 3, 2023

View reviewed changes

dimaMachina mentioned this pull request May 22, 2023

fix duplicated vite config #3180

Merged

dimaMachina mentioned this pull request Jun 30, 2023

pnpm + turbo (no cjs + no ts project refs) #3306

Draft

14 tasks

acao closed this Jun 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

introduce pnpm, fix build tooling #3054

introduce pnpm, fix build tooling #3054

acao commented Feb 25, 2023 •

edited

Loading

changeset-bot bot commented Feb 25, 2023 •

edited

Loading

github-actions bot commented Feb 26, 2023

dimaMachina Apr 30, 2023

dimaMachina Apr 30, 2023

dimaMachina Apr 30, 2023

dimaMachina Apr 30, 2023

dimaMachina Apr 30, 2023

dimaMachina Apr 30, 2023 •

edited

Loading

dimaMachina Apr 30, 2023

acao May 2, 2023

dimaMachina Apr 30, 2023

acao May 2, 2023

dimaMachina May 3, 2023

dimaMachina Apr 30, 2023

dimaMachina Apr 30, 2023

dimaMachina Apr 30, 2023

dimaMachina Apr 30, 2023

dimaMachina Apr 30, 2023

dimaMachina Apr 30, 2023

dimaMachina Apr 30, 2023

dimaMachina Apr 30, 2023

acao commented May 2, 2023

acao commented May 3, 2023 •

edited

Loading

acao commented May 3, 2023

dimaMachina commented May 3, 2023

acao commented May 3, 2023

dimaMachina May 3, 2023

acao commented May 3, 2023

dimaMachina commented May 3, 2023

acao commented May 3, 2023

	1. `pnpm` and `pnpm start` from this folder to start parcel dev mode.
	1. `pnpm i` and `pnpm start` from this folder to start parcel dev mode.

	In this directory, you can just run `pnpm` and `pnpm start`
	In this directory, you can just run `pnpm i` and `pnpm start`

	`pnpm` and `pnpm start` from this folder to start webpack dev server
	`pnpm i` and `pnpm start` from this folder to start webpack dev server

	"@graphiql/toolkit": "^0.8.0",
	"@graphiql/toolkit": "workspace:*",

	pnpm global add graphql-language-service-cli
	pnpm add -g graphql-language-service-cli

	${bright('pnpm global add graphql-language-service-cli')}
	${bright('pnpm add -g graphql-language-service-cli')}

	${bright('pnpm global remove graphql-language-service')}
	${bright('pnpm remove -g graphql-language-service')}

	// ['workspace', `vscode-graphql`, 'run', 'release', '--pre'],
	// ['--filter', `vscode-graphql`, 'release', '--pre'],

		vite.config.js
		vite.config.d.ts

introduce pnpm, fix build tooling #3054

introduce pnpm, fix build tooling #3054

Conversation

acao commented Feb 25, 2023 • edited Loading

changeset-bot bot commented Feb 25, 2023 • edited Loading

⚠️ No Changeset found

github-actions bot commented Feb 26, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dimaMachina Apr 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acao commented May 2, 2023

acao commented May 3, 2023 • edited Loading

acao commented May 3, 2023

dimaMachina commented May 3, 2023

acao commented May 3, 2023

Choose a reason for hiding this comment

acao commented May 3, 2023

dimaMachina commented May 3, 2023

acao commented May 3, 2023

acao commented Feb 25, 2023 •

edited

Loading

changeset-bot bot commented Feb 25, 2023 •

edited

Loading

dimaMachina Apr 30, 2023 •

edited

Loading

acao commented May 3, 2023 •

edited

Loading