Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin undici, config versions in lsp to fix introspection bug #2624

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

acao
Copy link
Member

@acao acao commented Aug 2, 2022

I believe this will fix #2619

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2022

⚠️ No Changeset found

Latest commit: 2bc89b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@acao acao force-pushed the fix-lsp-introspection-fetch branch from f9fca95 to 2bc89b9 Compare August 2, 2022 10:36
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #2624 (2bc89b9) into main (2d91916) will increase coverage by 3.78%.
The diff coverage is 23.84%.

@@            Coverage Diff             @@
##             main    #2624      +/-   ##
==========================================
+ Coverage   65.70%   69.49%   +3.78%     
==========================================
  Files          85       71      -14     
  Lines        5106     4206     -900     
  Branches     1631     1411     -220     
==========================================
- Hits         3355     2923     -432     
+ Misses       1747     1278     -469     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-react/src/utility/debounce.ts 0.00% <0.00%> (ø)
packages/graphiql-react/src/editor/tabs.ts 5.66% <5.66%> (ø)
packages/codemirror-graphql/src/variables/lint.ts 47.61% <66.66%> (+0.63%) ⬆️
packages/codemirror-graphql/src/hint.ts 94.73% <100.00%> (ø)
... and 99 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@acao acao merged commit 0f7d7bb into main Aug 2, 2022
@acao acao deleted the fix-lsp-introspection-fetch branch August 2, 2022 10:52
acao added a commit that referenced this pull request Aug 2, 2022
schema lsp introspection should work again.

swap out test mock as `@graphql-tools/url-loader` replaced `cross-undici-fetch` with `@whatwg-node/fetch`
acao added a commit that referenced this pull request Aug 2, 2022
schema lsp introspection should work again.

swap out test mock as `@graphql-tools/url-loader` replaced `cross-undici-fetch` with `@whatwg-node/fetch`
@acao acao mentioned this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"this.splice() is not a function" error on vscode-graphql startup
1 participant