-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix monaco-graphql bug with _cacheSchemas()
#2105
Conversation
🦋 Changeset detectedLatest commit: 3ef32d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest changes of this PR are available as canary in npm (based on the declared |
76b8635
to
dd8df38
Compare
_cacheSchemas()
Codecov Report
@@ Coverage Diff @@
## main #2105 +/- ##
==========================================
- Coverage 65.70% 64.66% -1.04%
==========================================
Files 85 77 -8
Lines 5106 5168 +62
Branches 1631 1641 +10
==========================================
- Hits 3355 3342 -13
- Misses 1747 1822 +75
Partials 4 4
Continue to review full report at Codecov.
|
c51ba4b
to
0305891
Compare
0305891
to
3ef32d1
Compare
Introduced this slight bug with major impact to
monaco-graphql
last night whilst moving things around.Actual Behavior:
No language features appear. Schema request completes but the editor doesn't appear to load features.
Expected behavior:
Language features should appear
Followup:
Need a basic jest and/or cypress suite for
monaco-graphql
asap! Jest looks difficult withmonaco-editor
from what I've read