use temporary fork of picomatch based on browser support PR #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 12f477c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
acao
force-pushed
the
fix/picomatch-fork
branch
from
ff4c7ac to
0ec0b01
Compare
Codecov Report
@@ Coverage Diff @@
## main #2101 +/- ##
==========================================
- Coverage 65.70% 63.33% -2.38%
==========================================
Files 85 79 -6
Lines 5106 5280 +174
Branches 1631 1666 +35
==========================================
- Hits 3355 3344 -11
- Misses 1747 1932 +185
Partials 4 4
Continue to review full report at Codecov.
|
github-actions
bot
temporarily deployed
to
monaco-graphql-webpack-preview
|
The latest changes of this PR are available as canary in npm (based on the declared |
acao
force-pushed
the
fix/picomatch-fork
branch
from
0ec0b01 to
12f477c
Compare
github-actions
bot
temporarily deployed
to
monaco-graphql-webpack-preview
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
micromatch/picomatch#73
introduces browser support for
picomatchI created a temporary npm package as a fork of
picomatchthat includes the changes in this PRpicomatchworks fine with CRA and other common webpack configs, but not so well with vite and some other bunders.I can confirm that this fixes the issue in vite:
https://stackblitz.com/edit/vitejs-vite-nsepqi?file=src%2Fmain.tsx