Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-expand selection sets & invoke completion with all fields on newline #2081

Merged
merged 1 commit into from
Dec 5, 2021

Conversation

acao
Copy link
Member

@acao acao commented Dec 5, 2021

introduces insertText and completion for field selectionSets for the appropriate field.types
works across the lsp ecosystem where insertText is used, such as monaco-graphql and graphql-language-service-server.

Screenshot 2021-12-05 at 18 01 18.

though the changeset is bumping a patch for codemirror-graphql, insertText is not used by codemirror, and thus this will not change the codemirror-graphql experience.

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2021

🦋 Changeset detected

Latest commit: aea19ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphql-language-service-interface Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #2081 (5b0d3c8) into main (2d91916) will decrease coverage by 1.89%.
The diff coverage is 70.89%.

❗ Current head 5b0d3c8 differs from pull request most recent head aea19ea. Consider uploading reports for the commit aea19ea to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2081      +/-   ##
==========================================
- Coverage   65.70%   63.81%   -1.90%     
==========================================
  Files          85       94       +9     
  Lines        5106     5516     +410     
  Branches     1631     1703      +72     
==========================================
+ Hits         3355     3520     +165     
- Misses       1747     1991     +244     
- Partials        4        5       +1     
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/components/QueryEditor.tsx 63.96% <ø> (ø)
...graphiql/src/components/__tests__/ExampleSchema.ts 100.00% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b06fff...aea19ea. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2021

@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 5, 2021 16:39 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2021

The latest changes of this PR are available as canary in npm (based on the declared changesets):

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2021

@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 5, 2021 16:40 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2021

@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview December 5, 2021 16:41 Inactive
@acao acao changed the title Auto-expand selection sets & invoke completion on newline Auto-expand selection sets & invoke all field completion on newline Dec 5, 2021
@acao acao changed the title Auto-expand selection sets & invoke all field completion on newline Auto-expand selection sets & invoke completion with all fields on newline Dec 5, 2021
@acao acao force-pushed the feat/selection-set-expansion branch from ce7bb8b to 9b5494e Compare December 5, 2021 16:58
@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 5, 2021 17:01 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 5, 2021 17:01 Inactive
@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview December 5, 2021 17:02 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 5, 2021 17:19 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 5, 2021 17:19 Inactive
@acao acao force-pushed the feat/selection-set-expansion branch from 5b0d3c8 to aea19ea Compare December 5, 2021 17:20
@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 5, 2021 17:23 Inactive
@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview December 5, 2021 17:24 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 5, 2021 17:24 Inactive
@acao acao merged commit 9b72af5 into main Dec 5, 2021
@acao acao deleted the feat/selection-set-expansion branch December 5, 2021 17:25
This was referenced Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement lsp-server graphql-language-service-server monaco-graphql
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant