-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip config updates when no custom filename is defined #1951
Conversation
de46aba
to
fa6f604
Compare
🦋 Changeset detectedLatest commit: 0f8c350 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks so much for opening a PR for this! |
fa6f604
to
5fb44c1
Compare
@acao I think this is ready for review 🙏 Please let me know if I should be tagging anyone else in! |
a889e98
to
6acde4f
Compare
@acao @dotansimha any chance we can get this in? I'm running into the same bug |
Really not sure what is wrong with github actions for this PR. When I get a chance, I will try lint/tests locally so we can get this one merged, high priority! Another matter, but I think we also need to debounce config updates when editing a config file |
I think it was an issue with GH Actions, not specific with this PR. |
Codecov Report
@@ Coverage Diff @@
## main #1951 +/- ##
==========================================
+ Coverage 65.70% 66.45% +0.75%
==========================================
Files 85 86 +1
Lines 5106 5143 +37
Branches 1631 1640 +9
==========================================
+ Hits 3355 3418 +63
+ Misses 1747 1721 -26
Partials 4 4
Continue to review full report at Codecov.
|
thank you @dotansimha ! Yes I think this was just a day with outages. Merging this now :) great work @GoodForOneFare !! |
Skip config reload when no custom filename is defined. Previously, any project without a
load.fileName
configuration would reload configuration on every change event. This is becausematch(undefined)
always returns true.