Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regressions in variables completion #1622

Closed
acao opened this issue Jul 28, 2020 · 0 comments · Fixed by #1624
Closed

regressions in variables completion #1622

acao opened this issue Jul 28, 2020 · 0 comments · Fixed by #1624

Comments

@acao
Copy link
Member

acao commented Jul 28, 2020 •
edited
Loading

getAutocompleteSuggestions was not updated to handle the parser fix for non-null list types, so variable completion was not working at all. we need to handle non-null list types, otherwise completion was not working. this would have impacted graphiql, codemirror-graphql, monaco-graphql, as well as the language server.

related to #1565 which was fixed for validation

addressed in #1616 for the next minor version for graphql-config@3 without watchman, however I'd like to patch the fix in a quick PR for for folks still using watchman and graphql-config@2
@acao acao mentioned this issue Jul 29, 2020
Merged
7 tasks
acao added a commit to acao/graphiql that referenced this issue Jul 29, 2020
@acao
fix: regression for variable def completion graphql#1622
0d4f19b
@acao acao mentioned this issue Jul 29, 2020
Merged
acao added a commit that referenced this issue Jul 30, 2020
@acao
fix: regression for variable def completion #1622 (#1624)
4f62a8f 
impacts graphiql, codemirror-graphql, monaco-graphql, and the lsp server. non null list types as variables had a parser bugfix, and we overlooked how that impacted code completion for variable definitions
thenamankumar pushed a commit to thenamankumar/graphiql that referenced this issue Aug 30, 2020
@acao @thenamankumar
fix: regression for variable def completion graphql#1622 (graphql#1624)
6a738f6 
impacts graphiql, codemirror-graphql, monaco-graphql, and the lsp server. non null list types as variables had a parser bugfix, and we overlooked how that impacted code completion for variable definitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: regression for variable def completion #1622 acao/graphiql
1 participant
@acao