[ESLint] enable logical-assignment-operators rule (#3036)

* enable `logical-assignment-operators` rule * Update GraphQLCache.ts * format
graphql · Feb 24, 2023 · 7a89c7d · 7a89c7d
1 parent 708c428
commit 7a89c7d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -250,6 +250,11 @@ module.exports = {
     'promise/no-multiple-resolved': 'error',
     'sonarjs/no-redundant-jump': 'error',
     'unicorn/prefer-logical-operator-over-ternary': 'error',
+    'logical-assignment-operators': [
+      'error',
+      'always',
+      { enforceForIfStatements: true },
+    ],
     'unicorn/prefer-export-from': ['error', { ignoreUsedVariables: true }],
     'unicorn/throw-new-error': 'error',
     'unicorn/prefer-includes': 'error',

diff --git a/examples/monaco-graphql-webpack/src/index.ts b/examples/monaco-graphql-webpack/src/index.ts
@@ -23,15 +23,13 @@ async function render() {
 
     return;
   }
-  if (!monacoGraphQLAPI) {
-    monacoGraphQLAPI = initializeMode({
-      formattingOptions: {
-        prettierConfig: {
-          printWidth: 120,
-        },
+  monacoGraphQLAPI ||= initializeMode({
+    formattingOptions: {
+      prettierConfig: {
+        printWidth: 120,
       },
-    });
-  }
+    },
+  });
 
   document.getElementById('github-login-wrapper')?.remove();
   document

diff --git a/packages/graphql-language-service-server/src/GraphQLCache.ts b/packages/graphql-language-service-server/src/GraphQLCache.ts
@@ -69,10 +69,7 @@ export async function getGraphQLCache({
   loadConfigOptions: LoadConfigOptions;
   config?: GraphQLConfig;
 }): Promise<GraphQLCache> {
-  let graphQLConfig = config;
-  if (!graphQLConfig) {
-    graphQLConfig = await loadConfig(loadConfigOptions);
-  }
+  const graphQLConfig = config || (await loadConfig(loadConfigOptions));
   return new GraphQLCache({
     configDir: loadConfigOptions.rootDir as string,
     config: graphQLConfig as GraphQLConfig,