Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up the docstrings of hybrid properties #344

Merged

Conversation

bim9262
Copy link
Contributor

@bim9262 bim9262 commented May 4, 2022

@erikwrede, I had deleted my repo, so this is a new PR to replace #298.

The issue that I had with SQA <1.3.19 regarding the ordering of all_orm_descriptors
is resolved by sorting list(ReporterType._meta.fields.keys()) .

Copy link
Member

@erikwrede erikwrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for reopening this!

@bim9262
Copy link
Contributor Author

bim9262 commented May 4, 2022

You're welcome!

@erikwrede erikwrede merged commit a47dbb3 into graphql-python:master May 5, 2022
Copy link
Contributor

@flipbit03 flipbit03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR! Thank you @bim9262

@bim9262 bim9262 deleted the hybrid_property_description branch May 6, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants