Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade react to 16 #111

Merged
merged 1 commit into from
May 27, 2020
Merged

upgrade react to 16 #111

merged 1 commit into from
May 27, 2020

Conversation

mac2000
Copy link
Contributor

@mac2000 mac2000 commented May 27, 2020

have upgraded react to 16, required for #103, everything compiles, editor works without errors, everything seems to be ok, in either case this is so small change that can be reverted pretty easy at any time

@IvanGoncharov IvanGoncharov merged commit f265e4c into graphql-kit:master May 27, 2020
@IvanGoncharov
Copy link
Member

@mac2000 Great 👍
I really like iterative development so if you see any other fix or improvements please feel free to submit PRs.

Also if you have time for it, moving all configs and package.json from src/editor into repository root will greatly improve the development experience.

"react": "15.6.2",
"react-dom": "15.6.2"
"react": "^16.13.1",
"react-dom": "^16.13.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mac2000 One note please keep exact versions in package.json it helps a lot with debugging dependencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants