Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: organization access tokens #6493
base: main
Are you sure you want to change the base?
feat: organization access tokens #6493
Changes from all commits
35cfca6
83daaeb
cfb17b7
d68fd71
1e73473
563c69b
0adf265
5ad7426
3deed76
66165f3
faa9452
68cf46e
440121f
1587b4c
58fc5bf
1ff1081
60ab85b
acb9e30
90c68ca
fa7e965
90434ed
fae1421
1b17d26
8f6096a
222491b
f3ee9f3
67da178
766102f
6109e97
cc7c340
8c38327
b98959d
96abc14
1a28781
346f2d2
e9959eb
f4a8679
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of returning null, do we want to capture this case to return more specific error messages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I think we do not really want to tell a potential brute-forcer that he correctly guessed the access key id, but not the private key part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. I picked a condition at random to add this comment to. But more generically for any of these null cases -- would it be worth providing info to the user? E.g.
Malformed token
if it doesnt start with Bearer?I suspect still the answer is no, but wanted to make sure i wasnt missing something.