Further refactor adapter handling, BlockStream, BlockIngestor #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangas
changed the title
neysofu
requested changes
Mar 3, 2023
neysofu
approved these changes
Mar 3, 2023
lutter
requested changes
Mar 3, 2023
There was a problem hiding this comment.
My main concern with this PR is that it changes some connection errors during startup into panics. We've had situations where it was not possible to start the block ingestor for all chains successfully, and we should make sure that that continues to work even if some chain clients have lost their mind.
node/src/main.rs
Outdated
| .collect(), | ||
| ) | ||
| } | ||
| fn chains_to_ingestor( |
There was a problem hiding this comment.
This function seems to not be used, no idea why rustc doesn't spot that
lutter
reviewed
Mar 3, 2023
lutter
approved these changes
Mar 6, 2023
node/src/main.rs
Outdated
| $acc.push(ingestor); | ||
| } | ||
| Err(err) => error!(&logger, | ||
| "Failed to create block ingestor for network {}",err), |
There was a problem hiding this comment.
Better wording: "Failed to create block ingestor: {}", err
- Move BlockIngestor init done by Blockchain trait - BlockIngestor is now a trait - BlockStream init now done by Blockchain trait - Adapter not sticky on BlockIngestor and BlockStream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
#4415
#4416