Refactor integration tests #4249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neysofu
force-pushed
the
filippo/refactor-integration-tests
branch
from
3286c3f to
b608b3c
Compare
neysofu
force-pushed
the
filippo/refactor-integration-tests
branch
4 times, most recently
from
02a02ee to
f50e0b1
Compare
leoyvens
approved these changes
Jan 30, 2023
mangas
approved these changes
Feb 3, 2023
neysofu
force-pushed
the
filippo/refactor-integration-tests
branch
2 times, most recently
from
dcc57ec to
2c448fb
Compare
In preparation to splitting tests/integration-tests/ into 2 directories, we want common/ to be easily accessible from both, so I'm moving it up a level.
neysofu
force-pushed
the
filippo/refactor-integration-tests
branch
from
2c448fb to
c974657
Compare
This reverts commit c974657.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring of our integration tests and "runner" tests.
tests/runner-tests/, marking a clear separation between integration and runner tests. The newyarn.lockis a duplicate of the one we already had.runner_tests.rsis mostly untouched. There's a new helper calledRunnerTestRecipe, but that's about it.tokio::join!a lot of.await's, to run things as fast as possible. I also removed the code that waits 100ms after every output line, which I think was inserted out of an abundance of caution but doesn't seem to help with test flakiness.parallel_tests.rs(renamed tointegration_tests.rsfor consistency), which mostly doesn't impact the way tests are run.