Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/postgres: warn if locale is not en_US.utf8 #3671

Closed
wants to merge 8 commits into from
Closed

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Jun 15, 2022

Check for user's locale on startup and if it is not en_US.utf8 panic.

Closes #3118

@leoyvens
Copy link
Collaborator

We need a guide for what an indexer should do when encountering this error, and the error message should link to that guide.

@saihaj saihaj self-assigned this Jul 4, 2022
@saihaj saihaj requested review from dotansimha and azf20 July 5, 2022 15:28
@azf20
Copy link
Contributor

azf20 commented Jul 12, 2022

@saihaj from discussion with @leoyvens , I think we may want to make the error message a bit more informative (i.e. directing the user to change their DB locale to match, or change the env variable)

@lutter
Copy link
Collaborator

lutter commented Jul 19, 2022

Here's how I think we should try and manage using the same locale for all indexers. We'll probably be stuck on en_US.UTF-8 because there are fewer indexers that need to change, though C would be more preferable for performance.

  1. Communicate a timeline and some writeup on what indexers need to do
  2. Print a warning when the locale is not the specified one for a while (probably months, definitely two releases)
  3. Switch to enforce the locale, i.e., the current behavior of panicking on startup

@saihaj saihaj changed the title store/postgres: panic if locale is not en_US.utf8 store/postgres: warn if locale is not en_US.utf8 Jul 27, 2022
@github-actions
Copy link

This pull request hasn't had any activity for the last 90 days. If there's no more activity over the course of the next 14 days, it will automatically be closed.

@github-actions github-actions bot added the Stale label Nov 17, 2022
@saihaj
Copy link
Member Author

saihaj commented Nov 17, 2022

#4163

@saihaj saihaj closed this Nov 17, 2022
@saihaj saihaj deleted the saihaj/3118 branch November 17, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Mandate everything runs in some fixed locale en_US.UTF8
5 participants