Refactor away guard from MetadataOperation::Update
#1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was only used in `update_ethereum_block_pointer_operations`, which in turn is only used in reverts or transact block. For transact block, the guard was made totally redundant as we now fetch the block in the same transaction. For reverts, I was more conservative and simply added an assert to replace the guard.
|
@lutter thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up to #1308 with some more simplification.
The guard was only used in
update_ethereum_block_pointer_operations, which in turn is only used in reverts or transact block.For transact block, the guard was made totally redundant as we now fetch the block in the same transaction. For reverts, I was more conservative and just added an assert to replace the guard.