Allow a data source to create another in the same block it was created #1185
Conversation
| let block_with_calls = EthereumBlockWithCalls { | ||
| ethereum_block: block.deref().clone(), | ||
| calls: calls.clone(), | ||
| }; |
There was a problem hiding this comment.
This code is wrong afaict, if the new data source contains call handlers for new addresses the call won't be contained here. But this is the way it was before so I will open an issue for fixing this.
There was a problem hiding this comment.
Looked into this and found that the calls will not be included in the block in the case where the data sources at the beginning of the block did not require them. The calls will be complete when they are included though.
…created Resolves #1105.
Use impl Trait in signature. Remove dead variables.
It's too small to exist by itself. Add note to the loop.
leoyvens
force-pushed
the
leo/create-data-source-on-creation-block
branch
from
605b4f1 to
256cc4a
Compare
| let block_with_calls = EthereumBlockWithCalls { | ||
| ethereum_block: block.deref().clone(), | ||
| calls: calls.clone(), | ||
| }; |
There was a problem hiding this comment.
Looked into this and found that the calls will not be included in the block in the case where the data sources at the beginning of the block did not require them. The calls will be complete when they are included though.
|
Thanks for the review! |
Resolves #1105, this involved some refactoring to
instance_manager::process_block.This was tested by uncommenting this line on this subgraph https://github.com/graphprotocol/aragon-subgraph/blob/sistemico/canary/canary/src/mappings/apm.ts#L42. Previously it would print the expected error, now it spawns the data source and processes its events on the same block.