Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject subgraphs with invalid @derivedFrom fields #1213

Closed
lutter opened this issue Sep 19, 2019 · 0 comments · Fixed by #1247
Closed

Reject subgraphs with invalid @derivedFrom fields #1213

lutter opened this issue Sep 19, 2019 · 0 comments · Fixed by #1247
Assignees
@lutter

Comments

@lutter
Copy link
Collaborator

lutter commented Sep 19, 2019

Graph CLI, since this commit disallows a number of errors around the @derivedFrom annotation. It is still possible to deploy such subgraphs to graph-node, e.g., by using an older version of graph-cli. The issues that graph-cli flags will become serious issues with the relational schema, and graph-node should reject new deployments of subgraphs with these problems
@lutter lutter self-assigned this Sep 19, 2019
@lutter lutter mentioned this issue Sep 23, 2019
Closed
lutter added a commit that referenced this issue Sep 28, 2019
@lutter
graph: Validate @derivedFrom directives on subgraph schemas
34cba0b 
These validations follow the corresponding validations in graph-cli, and
make sure users do not deploy invalid subgraphs, e.g., because they have
not updated their subgraph or graph-cli

Fixes #1213
@lutter lutter mentioned this issue Sep 28, 2019
Merged
lutter added a commit that referenced this issue Oct 1, 2019
@lutter
graph: Validate @derivedFrom directives on subgraph schemas
d0d9dca 
These validations follow the corresponding validations in graph-cli, and
make sure users do not deploy invalid subgraphs, e.g., because they have
not updated their subgraph or graph-cli

Fixes #1213
lutter added a commit that referenced this issue Oct 1, 2019
@lutter
graph: Validate @derivedFrom directives on subgraph schemas
3f1f520 
These validations follow the corresponding validations in graph-cli, and
make sure users do not deploy invalid subgraphs, e.g., because they have
not updated their subgraph or graph-cli

Fixes #1213
@lutter lutter closed this as completed in 0d59be3 Oct 1, 2019
leoyvens pushed a commit that referenced this issue Oct 2, 2019
@lutter @leoyvens
graph: Validate @derivedFrom directives on subgraph schemas
df716dd 
These validations follow the corresponding validations in graph-cli, and
make sure users do not deploy invalid subgraphs, e.g., because they have
not updated their subgraph or graph-cli

Fixes #1213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lutter lutter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

graph: Validate @derivedFrom directives on subgraph schemas graphprotocol/graph-node
1 participant
@lutter