Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relational schema: properly create HistoryEvent #1188

Closed
lutter opened this issue Sep 14, 2019 · 1 comment
Closed

Relational schema: properly create HistoryEvent #1188

lutter opened this issue Sep 14, 2019 · 1 comment
Assignees

Comments

@lutter
Copy link
Collaborator

lutter commented Sep 14, 2019

When we create a HistoryEvent, we write a row into event_meta_data. For relational schemas, that entry is neither needed nor used. We need to make sure that for relational schemas any HistoryEvent we create does not cause an entry in event_meta_data.

@lutter
Copy link
Collaborator Author

lutter commented Sep 16, 2019

This is tricky, because the subgraph of subgraphs still uses JSONB storage, and therefore any changes that involve metadata that needs to be versioned (like dynamic data sources) need an entry in event_meta_data.

We either have to make the decision whether to allocate in event_meta_data in transact_block_operations, or move all that logic entirely into the database and have a trigger on subgraphs.entities, though that risks collecting unnecessary history for metadata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant