fix: remove local_ppois_to_compare, refactor diverged_subgraphs #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Should be a better fix for the metrics
local_ppois_to_compare
was recorded at store and delete of local attestations but using the wrong values. The original intention for this metrics is to track the number of public POIs to compare, but this in theory is just the number of deployments being actively crosschecked. This PR deprecate this metrics as it doesn't represent true values of local state, in favor of the existing comparison tablediverged_subgraphs
was recorded at each comparison_result interval based on compared results. Some subgraphs have diverged state but considerednotFound
for certain intervals when they are waiting for the new block checkpoint. This PR adds a new function to grab the comparison results of a certain type from the persisted states, instead of relying on a particular comparison interval. This should improve stability of the metrics and better represent the true number of subgraphs with diverged results.Issue link (if applicable)
Resolves #70
Checklist