Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove local_ppois_to_compare, refactor diverged_subgraphs #81

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

hopeyen
Copy link
Collaborator

@hopeyen hopeyen commented Sep 18, 2023

Description

Should be a better fix for the metrics

  • local_ppois_to_compare was recorded at store and delete of local attestations but using the wrong values. The original intention for this metrics is to track the number of public POIs to compare, but this in theory is just the number of deployments being actively crosschecked. This PR deprecate this metrics as it doesn't represent true values of local state, in favor of the existing comparison table
  • diverged_subgraphs was recorded at each comparison_result interval based on compared results. Some subgraphs have diverged state but considered notFound for certain intervals when they are waiting for the new block checkpoint. This PR adds a new function to grab the comparison results of a certain type from the persisted states, instead of relying on a particular comparison interval. This should improve stability of the metrics and better represent the true number of subgraphs with diverged results.

Issue link (if applicable)

Resolves #70

Checklist

  • Are tests up-to-date with the new changes?
  • Are docs up-to-date with the new changes? (Open PR on docs repo if necessary)

@hopeyen hopeyen added type:bug Something isn't working size:small Small p1 High priority labels Sep 18, 2023
@hopeyen hopeyen requested a review from pete-eiger September 18, 2023 20:38
@hopeyen hopeyen self-assigned this Sep 18, 2023
@chriswessels
Copy link
Member

Very clear PR description, nice job!

@hopeyen hopeyen merged commit d68bbf5 into dev Sep 19, 2023
@hopeyen hopeyen deleted the hope/diverge-metrics-fix branch September 19, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 High priority size:small Small type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate Grafana behaviour
3 participants