Upgrades joaquin

[jackbravo]

Description

Attempts to fix cypress browser crash.

Using fix proposed at: cypress-io/github-action#104 (comment)

Performance impact

Security impact

Checklist

• My code matches the project's code style and yarn lint:fix passes.
• I've added tests for the new feature, and yarn test passes.
• I have detailed the new feature in the relevant documentation.
• I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
• If this is a breaking change I've explained why.

[jackbravo]

seems to not be running the cypress CI check, so this won't work 😛 .

[benjie]

Thanks for keeping chipping away at this @jackbravo. I've no idea what's up or even if it's Cypress' fault or if the issue lies elsewhere and Cypress is paying for it.

[jackbravo]

@benjie I feel like I need to install a virtual machine with ubuntu 16.04 to test cypress locally. This flow of testing is very slow :-p. And sadly my work machine today is a mac.

[benjie]

I'm running Ubuntu LTS 20.04 and can't reproduce here. I wonder if upgrading main branch's Cypress only would have the same issues?

[jackbravo]

I know that ubuntu-latest on github-actions means ubuntu 16.04. Maybe we could try using a newer ubuntu, but cypress is supposed to work on all versions: cypress-io/github-action#251

…

On Thu, Dec 10, 2020 at 9:59 AM Benjie Gillam ***@***.***> wrote: I'm running Ubuntu LTS 20.04 and can't reproduce here. I wonder if upgrading main branch's Cypress only would have the same issues? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#224 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAADW3QWEODQXUCB7CE5OPDSUDV7BANCNFSM4UP5DBJA> .

[mattvb91]

@jackbravo did you manage to make any progress with the out of memory? I upgraded our actions to Ubuntu 20.04 and still experiencing the same issue

[jackbravo]

@mattvb91 sadly I don't have made any progress, and haven't got the time to investigate other options.

[benjie]

I also attempted to fix it in #222 but no luck. Can anyone reproduce this outside of GitHub actions?

[benjie]

I've reproduced it locally! To do so was quite simple in the end:

NODE_ENV=test yarn build
NODE_ENV=test yarn server start &
NODE_ENV=test yarn worker start &
yarn e2e run run --browser chrome

Turns out we can't even load the browser in this circumstance either; the issue seems to be Next.js related rather than Cypress related! 🎉

[benjie]

We get an error like:

                               [                                                                                             
                                 {                                                                                                                              "type": "object",                                                                         
                                   "subtype": "error",                                                                                                          "className": "TypeError",                                                                                                    "description": "TypeError: Object(...) is not a function\n    at b.render (http://localhos
t:7777/_next/static/chunks/pages/_app-95a06bfb7a4260377f90.js:1:7029)\n    at Wo (http://localhost:7777/_next/static/chunks/framework.b334d46914b6052ad622.js:1:102515)\n    at jo (http://localhost:7777/_next/static/chunks/framework.b334d46914b6052ad622.js:1:102312)\n    at Wi (http://localhost:7777/_next/static/chunks/framework.b334d46914b6052ad622.js:1:143599)\n    at xu 
(http://localhost:7777/_next/static/chunks/framework.b334d46914b6052ad622.js:1:129506)\n    at Su (http://localhost:7777/_next/static/chunks/framework.b334d46914b6052ad622.js:1:129434)\n    at ku (http://localhost:7777/_next/static/chunks/framework.b
334d46914b6052ad622.js:1:129297)\n    at pu (http://localhost:7777/_next/static/chunks/framework.b334d46914b6052ad622.js:1:126263)\n    at http://localhost:7777/_next/static/chunks/framework.b334d46914b6052ad622.js:1:75652\n    at t.unstable_runWithPriority (http://localhost:7777/_next/static/chunks/framework.b334d46914b6052ad622.js:1:10121)",                              
                                   "objectId": "{\"injectedScriptId\":12,\"id\":8563}",

Seems to be related to Object(s.jsxDEV) not being a function (probably not existing).

[benjie]

Fixed in 3afcb19 (#222)

[benjie]

Thanks for your help debugging this everyone! Turned out to be next build not working quite right in NODE_ENV=test