Implement self-attention and update utils #9
Conversation
|
@DouglasOrr Added some changes. I think this is much less scary now 😱 |
| """run Python with the current directory on PYTHONPATH, for development""" | ||
| run(["python"] + command) | ||
| run(["python"] + list(command)) |
There was a problem hiding this comment.
I don't think this is right. I've played around & I think you instead want to rename command to commands or in L166: rename "command" there, which is conflicting.
There was a problem hiding this comment.
I'm confused 🤔 Does my code error for you? If I run ./dev python it works fine.
If I change it to:
def python(*commands: Any) -> None:
"""run Python with the current directory on PYTHONPATH, for development"""
run(["python"] + commands)
I'm getting:
...
run(["python"] + commands)
TypeError: can only concatenate list (not "tuple") to list
There was a problem hiding this comment.
Ah, sorry I meant the main thing is to drop the varargs *.
I think with the currently committed version maybe ./dev python works but ./dev python my_script.py doesn't.
There was a problem hiding this comment.
Ah yes, I forgot what it looked like before. If it's ok I'll make this change in the next pr (makes my life slightly easier with git 🙃 )
No description provided.