fix sgd bug and add demo notebook #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DouglasOrr
approved these changes
Oct 24, 2024
unit_scaling/tests/test_optim.py
Outdated
| @@ -48,7 +48,7 @@ def test_scaled_parameters(opt: str) -> None: | |||
| base_wd = 0.001 | |||
| param_groups = scaled_parameters( | |||
| model.parameters(), | |||
| dict(sgd=lr_scale_func_sgd, adam=lr_scale_func_adam)[opt], | |||
| dict(sgd=lr_scale_func_sgd("to_output_scale"), adam=lr_scale_func_adam)[opt], | |||
There was a problem hiding this comment.
I wonder if we should instead change the final layer to a LinearReadout and use this to test the new behaviour?
There was a problem hiding this comment.
I've done this, and corrected the input scaling rule which I hadn't actually adjusted. It then clicked that in this case it now (of course!) reduces to the adam rules, so I've modified the code to reflect this.
DouglasOrr
approved these changes
Oct 24, 2024
thecharlieblake
force-pushed
the
fix-sgd-scaling
branch
from
860223e to
60f8f6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.