Use operationName from query if missing from POST #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willnewrelic
commented
Jan 28, 2020
| // Subscriptions are not valid in Exec. Use schema.Subscribe() instead. | ||
| if op.Type == query.Subscription { | ||
| return &Response{Errors: []*errors.QueryError{&errors.QueryError{ Message: "graphql-ws protocol header is missing" }}} | ||
| return &Response{Errors: []*errors.QueryError{&errors.QueryError{Message: "graphql-ws protocol header is missing"}}} |
There was a problem hiding this comment.
My text editor likes gofmt. It can't help itself!
|
Thank you for your contribution. In future try not to combine logical changes with formatting changes, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Here at New Relic we're working on creating instrumentation for this repo! The
Tracerinterface is working great!I've noticed that when the
"operationName"POST parameter is missing, theTraceQueryhook is never given anoperationNameeven if there's an operation name in the query. This is unfortunate because having an operation name is very useful, and the"operationName"POST parameter is optional (https://graphql.org/learn/serving-over-http/#post-request).Thanks for your consideration!