This repository has been archived by the owner on Dec 8, 2024. It is now read-only.
Add reader support for EXT-OATCLS-SCTE35 and EXT-X-CUE-OUT #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Breaking Change**: SCTE struct was renamed to SCTE35 **Breaking Change**: MediaSegment.SCTE was renamed to MediaSegment.SCTE35 **Deprecation**: MediaPlaylist.SetSCTE() has been deprecated, use MediaPlaylist.SetSCTE35() instead SCTE35 (was SCTE) has 3 new fields, SCTE35.Syntax defines the format of the SCTE data, SCTE35.CueType defines whether the cue point was start/mind/end, SCTE35.Elapsed can be used for formats that track the elapsed time. SCTE35 now supports another SCTE-35 syntax we've nicknamed OATCLS (due to the presence of this string in the tag), see sample-playlists/media-playlist-with-oatcls-scte35.m3u8 for an example. Both reads and writes are supported.
bradleyfalzon
force-pushed
the
oatcls-scte35
branch
from
dafb983 to
c29336f
Compare
|
Seems absolutely fine to me @bradleyfalzon 👍 |
bradleyfalzon
force-pushed
the
oatcls-scte35
branch
from
c29336f to
1f09c74
Compare
bradleyfalzon
force-pushed
the
oatcls-scte35
branch
from
1f09c74 to
638e5da
Compare
|
Thanks mate. @grafov when you have a moment, can you review as well. I'll do some internal testing, but keen to get this merged sooner rather than later now there's no breaking changes. |
grafov
approved these changes
Apr 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation: MediaPlaylist.SetSCTE() has been deprecated, use MediaPlaylist.SetSCTE35() instead
SCTEhas 3 new fields,.Syntaxdefines the format of theSCTE data,
.CueTypedefines whether the cue point was start/mind/end,.Elapsedcan be used for formats that track the elapsed time.SCTE now supports another SCTE-35 syntax we've nicknamed OATCLS (due
to the presence of this string in the tag), see
sample-playlists/media-playlist-with-oatcls-scte35.m3u8for an example. Both reads and writes are supported.