Skip to content
This repository has been archived by the owner on Dec 8, 2024. It is now read-only.

Expose master and media playlist version setter and getter methods #52

Merged
merged 1 commit into from
May 14, 2016
Merged

Expose master and media playlist version setter and getter methods #52

merged 1 commit into from
May 14, 2016

Conversation

bradleyfalzon
Copy link
Collaborator

Currently version is controlled via private version functions and
set via the Set* methods when required. This is the ideal method for
most applications, as the version is managed by the library

This change provides the user the ability to check the version as
well as overwrite it, as during some live streams the version number
may have been incremented via the Set methods, but once those
segments have been removed the version number will change during
playback. This isn't ideal as the player may encounter version changes
during playback to versions it doesn't support. This provides
implementors the ability to announce up front what the version number
will be.

Currently version is controlled via private version functions and
set via the Set* methods when required. This is the ideal method for
most applications, as the version is managed by the library

This change provides the user the ability to check the version as
well as overwrite it, as during some live streams the version number
may have been incremented via the Set methods, but once those
segments have been removed the version number will change during
playback. This isn't ideal as the player may encounter version changes
during playback to versions it doesn't support. This provides
implementors the ability to announce up front what the version number
will be.
@bradleyfalzon
Copy link
Collaborator Author

@grafov what's your thoughts on this? Is this acceptable new functionality?

@grafov
Copy link
Owner

grafov commented May 14, 2016

It is not break old behavior and seems like a reasonable feature. Let add it.

@bradleyfalzon bradleyfalzon merged commit 321517c into grafov:master May 14, 2016
grafov pushed a commit that referenced this pull request Nov 22, 2016
Currently version is controlled via private version functions and
set via the Set* methods when required. This is the ideal method for
most applications, as the version is managed by the library

This change provides the user the ability to check the version as
well as overwrite it, as during some live streams the version number
may have been incremented via the Set methods, but once those
segments have been removed the version number will change during
playback. This isn't ideal as the player may encounter version changes
during playback to versions it doesn't support. This provides
implementors the ability to announce up front what the version number
will be.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants