This repository has been archived by the owner on Dec 8, 2024. It is now read-only.
Correctly decode a Media manifest with BYTERANGE #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decodeLineOfMediaPlaylist currently expects a playlist to have
*either* a EXTINF or a EXT-X-BYTERANGE because it's using an
if EXTINF {} else if EXT-X-BYTERANGE {}, this is incorrect as
EXTINF is required and therefore a playlist must always have
an EXTINF, the EXT-X-BYTERANGE is optional.
This change also fixes a bug when an offset given in EXT-X-BYTERANGE
is not reset in its state, so segments without an offset would
incorrect be given the last offset set.
Also includes unit tests to reproduce the issue.
This was referenced May 4, 2016
|
@AyliD can you also check over this PR and verify it resolves your issue? |
|
@bradleyfalzon you are an angel, seems like the fix i made and working well for me (but i didnt write any unitesting) so thank you! |
|
Thanks for the issue and fixes, unless urgent I'll leave these around for 24hrs and let @grafov make any further suggestions/clarifications before merging. |
|
@AyliD thank you for explaining the problem! |
grafov
pushed a commit
that referenced
this pull request
Nov 22, 2016
decodeLineOfMediaPlaylist currently expects a playlist to have
*either* a EXTINF or a EXT-X-BYTERANGE because it's using an
if EXTINF {} else if EXT-X-BYTERANGE {}, this is incorrect as
EXTINF is required and therefore a playlist must always have
an EXTINF, the EXT-X-BYTERANGE is optional.
This change also fixes a bug when an offset given in EXT-X-BYTERANGE
is not reset in its state, so segments without an offset would
incorrect be given the last offset set.
Also includes unit tests to reproduce the issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decodeLineOfMediaPlaylist currently expects a playlist to have
either a EXTINF or a EXT-X-BYTERANGE because it's using an
if EXTINF {} else if EXT-X-BYTERANGE {}, this is incorrect as
EXTINF is required and therefore a playlist must always have
an EXTINF, the EXT-X-BYTERANGE is optional.
This change also fixes a bug when an offset given in EXT-X-BYTERANGE
does not reset its state, so segments without an offset would
incorrectly be given the offset of a previous segment.
Also includes unit tests to reproduce the issue.
Fixes #46