This repository has been archived by the owner on Dec 8, 2024. It is now read-only.
Remove normalize SeqNo. Allow starting 0 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hori-ryota
force-pushed
the
feature/modify-default-seqno
branch
2 times, most recently
from
eb0a3bf to
2a74ff4
Compare
hori-ryota
force-pushed
the
feature/modify-default-seqno
branch
from
2a74ff4 to
b65f348
Compare
|
@grafov Would you merge this? 🙏 |
|
I can't see any reason why this shouldn't be merged, we're also confused by this behaviour, and don't feel it's a breaking change. I've searched the history, and it looks like this behaviour has been here for some time. See b5ae3cd which maintained the behaviour in e559557 which appears to have added the SeqNo for a VoD (closed) playlist in 710ac2a - which makes references to Widevine? |
|
Yes-yes, it all will be merged soon sorry for delays. |
bradleyfalzon
added a commit
that referenced
this pull request
Mar 15, 2016
Remove normalize SeqNo. Allow starting 0
grafov
pushed a commit
that referenced
this pull request
Nov 22, 2016
Remove normalize SeqNo. Allow starting 0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Why replace seqNo 0 to 1? · Issue #37 · grafov/m3u8