This repository has been archived by the owner on Dec 8, 2024. It is now read-only.
Use segment Keyformat and Keyformatversions on MediaPlaylist.Encode() #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when a segment has different encryption parameters than the default playlist, the Encode() function uses the segment's parameters for all parameters but Keyformat and Keyformatversions. This change uses the segment's Keyformat and Keyformatversions when the segments are encoded, allowing these parameters to change per segment and not requiring a playlist to have a key set.
|
Any thoughts, concerns or changes you want for this? |
|
Very sorry for silence I'm busy on my work before NY so I can't switch to opensource projects until 2016. |
|
No problems mate, we'll maintain a separate fork until you have time. |
grafov
added a commit
that referenced
this pull request
Jan 9, 2016
Use segment Keyformat and Keyformatversions on MediaPlaylist.Encode()
|
Sorry for long delay, changes seems ok and was merged to master. Thank you for your contribution! |
grafov
added a commit
that referenced
this pull request
Nov 22, 2016
Use segment Keyformat and Keyformatversions on MediaPlaylist.Encode()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a segment has different encryption parameters than the
default playlist, the Encode() function uses the segment's parameters for
all parameters but
KeyformatandKeyformatversions.This change uses the segment's
KeyformatandKeyformatversionswhen thesegments are encoded, allowing these parameters to change per segment and
not requiring a playlist to have a key set.
An
Encode()at the end of theTestSetKeyForMediaPlaylisttest would show a nil pointer exception, as the playlist did not have a key initialised, but the Encode() function would try and access it anyway.