ci: add lint, pr, and release workflows #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Release job seems to be working fine: |
ka3de
approved these changes
Oct 8, 2024
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: golangci-lint | ||
| uses: golangci/golangci-lint-action@v6 |
There was a problem hiding this comment.
nit: Which configuration does this action use? It would make sense to make all the repos converge in the same linter configuration. I thought we did that for some repos when updating the makefiles etc, but that does not seem to be the case. If we want to do we could copy the one from sm-alerts repo, which I believe is the one that has been reviewed more recently.
There was a problem hiding this comment.
@ka3de Right now it is using the golangci defaults, it would be good to configure it. Feel free to open a PR with that config!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CI/CD workflows to this repo, namely a lint pipeline and a build/release pipeline.
The build/release pipeline is unified to avoid complex command duplication, and instead it just skips the uploading step if the context is that of a PR instead of a release being created.