This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Add K6_BROWSER_EXECUTABLE_PATH in ci #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
force-pushed
the
fix/ci-google-chrome
branch
3 times, most recently
from
2e13017 to
8ff018c
Compare
ankur22
force-pushed
the
fix/ci-google-chrome
branch
from
e65317e to
fa7e2a0
Compare
The github runners have both chromium and google chrome installed. Google chrome is kept up to date whereas chromium isn't. We want to work with the latest version of google chrome (for now, in the future we may want to install the exact version we want to work with). We've had issues working with chromium in the runners where the application crashes on startup.
ankur22
force-pushed
the
fix/ci-google-chrome
branch
4 times, most recently
from
0a455ba to
f704402
Compare
It's not known why this example doesn't work in the github action runner. It works fine on a Windows 11 computer.
ankur22
force-pushed
the
fix/ci-google-chrome
branch
10 times, most recently
from
ef03811 to
e0bf96e
Compare
ka3de
previously approved these changes
Aug 17, 2023
inancgumus
previously approved these changes
Aug 17, 2023
ankur22
force-pushed
the
fix/ci-google-chrome
branch
from
2be84e3 to
e0bf96e
Compare
ankur22
force-pushed
the
fix/ci-google-chrome
branch
3 times, most recently
from
02bd099 to
e0bf96e
Compare
The e2e workflow for windows using the tip version of go doesn't seem to work on Windows (or at least in the ci github action). The tip is installed correctly, but when it comes to building the k6 binary using xk6, xk6 seems to always execute the stable version of the go binary and not the tip version. When running commands outside of xk6 to verify the env vars (e.g. GOROOT) it always returns the tip paths. It's unclear why this is happening. For now, we're skipping the windows e2e tip workflow.
ankur22
force-pushed
the
fix/ci-google-chrome
branch
from
e0bf96e to
7d983cd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The main change (initially) was to work with the
K6_BROWSER_EXECUTABLE_PATHenv var on linux github actions to ensure it picks chrome and not chromium. The github runners have both chromium and google chrome installed. Google chrome is kept up to date whereas chromium isn't. We want to work with the latest version of google chrome (for now, in the future we may want to install the exact version we want to work with).I also found that the e2e workflow wasn't correctly using the defined matrix, and was only working with
ubuntu-latest. There are several commits which attempt to resolve this.Two issues which were discovered but not resolved in the e2e workflow were:
examples/hosts.jstest script doesn't pass in the Windows stable e2e test. When tested in a Windows 11 computer, the test passed. I've opened a new issue (Fix e2e & test CI workflows #963) to track this.GOROOTis pointing to the tip version and not the stable version that is already on the system), but even still xk6 works with the stable version of go which ends up with an error. This hasn't been tested on a standalone windows computer. I've opened a new issue (Investigate why tip e2e tests on Windows github action runner fails k6#4361) to track this.Closes: #963
Checklist