This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Enhance waitForSelector JavaScript error message #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
force-pushed
the
enhance/waitForSelectorJS
branch
from
f156cc2 to
5d5a56f
Compare
inancgumus
force-pushed
the
enhance/waitForSelectorJS
branch
from
5d5a56f to
9e85606
Compare
waitForSelector may result in a confusing error message:
selector did not resolve to any element
We're now explaining which selector didn't resolve to an element.
inancgumus
force-pushed
the
enhance/waitForSelectorJS
branch
from
9e85606 to
cb45b1b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and Why
See #1461 for details.
Checklist
Related PR(s)/Issue(s)
#1461