This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Refine PR and Issue templates #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
commented
Sep 1, 2023
inancgumus
commented
Sep 1, 2023
inancgumus
force-pushed
the
update/pr-issue-templates
branch
from
7c8c490 to
dbe00e2
Compare
inancgumus
commented
Sep 1, 2023
inancgumus
force-pushed
the
update/pr-issue-templates
branch
2 times, most recently
from
7b73e6e to
1030a9f
Compare
ka3de
reviewed
Sep 1, 2023
There was a problem hiding this comment.
Thanks for taking care of this @inancgumus ! 🙌
Just a few considerations.
We decided to keep the PR template concise.
inancgumus
force-pushed
the
update/pr-issue-templates
branch
from
1030a9f to
d0afa99
Compare
ankur22
previously approved these changes
Sep 1, 2023
ankur22
reviewed
Sep 1, 2023
Co-authored-by: Ankur Agarwal <[email protected]> Co-authored-by: ka3de <[email protected]>
inancgumus
force-pushed
the
update/pr-issue-templates
branch
from
4ffeaf1 to
bca88d4
Compare
inancgumus
added
productivity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I can't preview these templates, so IDK how they will look when rendered. Update: I found a suboptimal way. Go to the issue template file on the Github UI.
Why?
To provide better workflow both for internal and external contributors.