Reject recording rules with incompatible fields #2000
+83
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
|
Can you fill out the PR description? Otherwise, this looks good to me 👍 |
moustafab
reviewed
Jan 28, 2025
Comment on lines
+612
to
+635
| func checkFields(rule *models.ProvisionedAlertRule) error { | ||
| if rule.Record != nil { | ||
| incompatFieldMsgFmt := `"record" and "%s" cannot be set together` | ||
| if rule.For != nil { | ||
| return fmt.Errorf(incompatFieldMsgFmt, "for") | ||
| } | ||
| if rule.NoDataState != nil { | ||
| return fmt.Errorf(incompatFieldMsgFmt, "no_data_state") | ||
| } | ||
| if rule.ExecErrState != nil { | ||
| return fmt.Errorf(incompatFieldMsgFmt, "exec_err_state") | ||
| } | ||
| if rule.Condition != nil { | ||
| return fmt.Errorf(incompatFieldMsgFmt, "condition") | ||
| } | ||
| } | ||
|
|
||
| // condition is required if the rule is not a recording rule | ||
| if rule.Condition == nil { | ||
| return fmt.Errorf(`"condition" is required`) | ||
| } | ||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
I think you can achieve this via schema attributes like ConflictsWith and ExactlyOneOf which will give you the terraform validate function and language server some teeth to help users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.