-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for defining aws account name #1976
Conversation
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
the tests have an error like
looks like you need to add the field changes in https://github.com/grafana/terraform-provider-grafana/pull/1976/files#diff-2c8e971fa27a2dc1c948b60dbcb7111f4106eafe5ced1ccdf070a142c38db3b6 to the data source stuff as well: https://github.com/grafana/terraform-provider-grafana/blob/main/internal/resources/cloudprovider/data_source_aws_account.go |
6819096
to
39dcf88
Compare
looks like still a few errors from the tests
|
2d3bf37
to
e9cc3e3
Compare
e9cc3e3
to
aac9f26
Compare
@tristanburgess this should be good now |
This PR adds support in the cloud-provider section of the provider, to define an optional
name
for agrafana_cloud_provider_aws_account
resouce, which will help users keep a human readable name in the accounts.Part of https://github.com/grafana/grafana-csp-app/issues/296