Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static labels to the CloudWatch jobs #1974

Merged
merged 13 commits into from
Feb 6, 2025

Conversation

andriikushch
Copy link
Contributor

@andriikushch andriikushch commented Jan 3, 2025

This PR adds support for setting the static labels that will be added to the Cloudwatch job's metrics.

Copy link

github-actions bot commented Jan 3, 2025

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@andriikushch andriikushch changed the title Add static labels to the CloudWatch jobs [WIP] Add static labels to the CloudWatch jobs Jan 3, 2025
@andriikushch andriikushch marked this pull request as ready for review January 3, 2025 10:52
@andriikushch andriikushch requested review from a team as code owners January 3, 2025 10:52
@andriikushch andriikushch changed the title [WIP] Add static labels to the CloudWatch jobs Add static labels to the CloudWatch jobs Jan 29, 2025
@andriikushch andriikushch marked this pull request as draft January 29, 2025 16:34
@andriikushch andriikushch marked this pull request as ready for review January 30, 2025 10:12
Copy link
Contributor

@thepalbi thepalbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have you tried it out locally overriding the provider, to use a local build?

@andriikushch
Copy link
Contributor Author

LGTM, have you tried it out locally overriding the provider, to use a local build?

@thepalbi , yes I tried it.

@andriikushch andriikushch merged commit 35f15e2 into main Feb 6, 2025
26 checks passed
@andriikushch andriikushch deleted the andrii/add-custom-labels-to-the-cw-job branch February 6, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants