Implement search in vulture #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalegrala
requested review from
annanay25,
dgzlopes,
joe-elliott,
yvrhdn,
mapno and
mdisibio
as code owners
zalegrala
commented
Sep 9, 2021
zalegrala
force-pushed
the
vultureSearch
branch
5 times, most recently
from
f8340df to
3059519
Compare
joe-elliott
requested changes
Sep 10, 2021
|
Thanks for the review and the good suggestions. I believe I addressed all the feedback. |
joe-elliott
reviewed
Sep 13, 2021
cmd/tempo-vulture/main.go
Outdated
| } | ||
|
|
||
| // Do the same for the startTime we've just selected | ||
| if seed.Before(startTime.Add(tempoWriteBackoffDuration)) { |
There was a problem hiding this comment.
does this matter? if startTime > actualStartTime it means that vulture has been running longer than the retention period which means there shouldn't be a race condition?
There was a problem hiding this comment.
I've adjusted the search and read loops to use the simpler logic. Thanks for the suggestion.
zalegrala
force-pushed
the
vultureSearch
branch
5 times, most recently
from
c4b1ca9 to
72e03b4
Compare
3 tasks
mapno
approved these changes
Sep 14, 2021
|
|
||
| attr := randomAttrFromTrace(expected, r) | ||
| if attr == nil { | ||
| return tm, fmt.Errorf("no search attr selected from trace") |
There was a problem hiding this comment.
Should we add this failure as a metric?
There was a problem hiding this comment.
I think so, good point.
zalegrala
force-pushed
the
vultureSearch
branch
from
72e03b4 to
d1f6e5e
Compare
joe-elliott
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Here we include a Vulture update to exercise the search API in Tempo and report on the results.
Which issue(s) this PR fixes:
Fixes #922
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]