Add initial instrumentation to Azure #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
josephwoodward
commented
Jun 15, 2021
annanay25
approved these changes
Jun 15, 2021
There was a problem hiding this comment.
LGTM, thanks @josephwoodward. Can you please add a CHANGELOG entry with the new metric name?
joe-elliott
reviewed
Jun 15, 2021
josephwoodward
requested review from
dgzlopes,
mapno and
mdisibio
as code owners
josephwoodward
force-pushed
the
AddAzureInstrumentation
branch
from
7eb5743 to
48d6989
Compare
Done 👍 |
Closed
|
Metrics are now showing for Azure:
|
joe-elliott
reviewed
Jun 16, 2021
joe-elliott
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Initial draft PR to add instrumentation to Azure.
Which issue(s) this PR fixes:
Fixes #759
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]