-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize docker-compose examples into subfolders #740
Conversation
This is looking really good so far, will keep reviewing. Agree with mounting the I think some (all?) of the examples are missing the dashboards now. Any example that runs tempo/prometheus/grafana should have the tempo dashboards mounted too. One more thing: this isn't related to the changes in this PR, but I would like to reconsider the order of examples described in the readme. The first example in the list is the Loki example, but I'm not sure that is the best for new users. The local-storage example is probably the simplest and ideal to list first. |
Yeah, I dropped all the dashboards because they didn't work. Looking into why a bit more: all graphs have labels using I've figured out how to add default labels using So I guess the underlying issue is that the dashboards are not made to work with single binary deployments. The different graphs expect labels per specific service.
I agree. Local is kind of the default example but it gets lost in the list of storage options. I'll try to highlight this example. |
101fd77
to
e071863
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I really like the changes, great work!
It's a shame we can't use the dashboards because it won't work with single binary deployments. I wonder if we could craft a compatible version with jsonnet.
Cortex does this: I don't think we should worry about fixing that as part of this PR though. |
I'll create an issue to keep track of the dashboards 👍 |
I did this on purpose b/c it should drive people to the "most complete" example so they can see how to use Loki to create links into Tempo. All of the other examples require copy/pasting trace ids and i didn't want people to think that was required to use Tempo. |
What this PR does:
Split all docker-compose examples into separate subfolders. I've also updated examples and made them more consistent with each other.
Browse through the new structure here: https://github.com/kvrhdn/tempo/tree/731-split-examples/example/docker-compose
Which issue(s) this PR fixes:
Fixes #731
TODO
docs/