Add per-tenant block retention #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-elliott
approved these changes
Feb 5, 2021
|
@joe-elliott is this a part of tempo 1.4.1? The docs state "Currenly only ingestion limits can be overridden." which makes me think this was backed out or its undocumented |
|
Yup, this feature has been in Tempo since 0.6.0. Thanks for the heads up. Pushing a fix to the docs now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds per-tenant block retention. Uses existing overrides.yaml system, value is optional, defaults to global retention. The callback design is done so that it continues to work with the overrides.yaml polling and use new limits without restarting.
This introduces a not-great situation where it is now possible to specify block retention in a third location: tempo.yaml ->
overrides.block_retention, which are the default limits, and would technically override the original value in tempo.yaml ->compactor.compaction.block_retention. This isn't harmful and unlikely to ever be used, but wanted to mention it.Which issue(s) this PR fixes:
Fixes #77
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]