Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakey ingester tests #4659

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Fix flakey ingester tests #4659

merged 1 commit into from
Feb 4, 2025

Conversation

mdisibio
Copy link
Contributor

@mdisibio mdisibio commented Feb 4, 2025

What this PR does:
Fixes some flakey ingester tests where the generated test data is a little larger or smaller than before and it's not above or below the tested limits anymore.

Example:

=== RUN   TestInstancePartialSuccess
    instance_test.go:641: 
        	Error Trace:	/Users/marty/src/tempo/modules/ingester/instance_test.go:641
        	Error:      	Not equal: 
        	            	expected: true
        	            	actual  : false
        	Test:       	TestInstancePartialSuccess
--- FAIL: TestInstancePartialSuccess (0.01s)

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@mdisibio mdisibio marked this pull request as ready for review February 4, 2025 21:14
@mdisibio mdisibio enabled auto-merge (squash) February 4, 2025 21:14
@mdisibio mdisibio merged commit 60245c6 into grafana:main Feb 4, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants