Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tempo serverless #4599

Merged
merged 11 commits into from
Jan 24, 2025
Merged

Remove tempo serverless #4599

merged 11 commits into from
Jan 24, 2025

Conversation

electron0zero
Copy link
Member

@electron0zero electron0zero commented Jan 23, 2025

What this PR does:
serverless was deprecated in tempo 2.7 release.

Tempo serverless related code, config options, and docs is being removed.

This PR Removes:

  1. serverless config options from the tempo config
    2.serverless doc pages and mention from the docs
  2. serverless dashboard panels from tempo-mixin, and removes mention of serverless from playbook

following config options are no longer valid:

querier:
    search:
        prefer_self: <int>
        external_hedge_requests_at: <duration>
        external_hedge_requests_up_to:  <duration>
        external_backend: <string>
        google_cloud_run: <string>
        external_endpoints: <array>

following serverless related metrics are being removed:

tempo_querier_external_endpoint_duration_seconds
tempo_querier_external_endpoint_hedged_roundtrips_total
tempo_feature_enabled

Which issue(s) this PR fixes:
Fixes #4014

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@electron0zero electron0zero changed the title remove tempo-serverless from cmd Remove tempo serverless Jan 23, 2025
Copy link
Contributor

@mdisibio mdisibio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Good bye serverless. Nice cleanup

CHANGELOG.md Show resolved Hide resolved
cmd/tempo/app/app.go Outdated Show resolved Hide resolved
docs/sources/tempo/operations/serverless_aws.md Outdated Show resolved Hide resolved
modules/querier/querier.go Outdated Show resolved Hide resolved
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o7 serverless

I'm good on this as well. Let's just wait for Kim to weigh in on removing the docs pages and then we can merge.

Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the doc! Changes look good! We should add an alias for any deleted pages. For an example of an alias: #4598 (comment)

Note that aliases use relative locations. For detailed instructions: https://grafana.com/docs/writers-toolkit/write/front-matter/#aliases

@electron0zero electron0zero enabled auto-merge (squash) January 24, 2025 04:46
@electron0zero electron0zero merged commit 51aca06 into grafana:main Jan 24, 2025
14 checks passed
@electron0zero electron0zero deleted the serverless branch January 24, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for serverless functions
4 participants