Bugfix: Default step for gRPC streaming query range queries #4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
joe-elliott
requested review from
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham,
stoewer and
javiermolinar
as code owners
Signed-off-by: Joe Elliott <[email protected]>
joe-elliott
changed the title
electron0zero
approved these changes
Jan 13, 2025
Signed-off-by: Joe Elliott <[email protected]>
joe-elliott
added a commit
to joe-elliott/tempo
that referenced
this pull request
Jan 17, 2025
…rafana#4546)" This reverts commit 424274a.
3 tasks
joe-elliott
added a commit
that referenced
this pull request
Jan 17, 2025
* Revert "Bugfix: Default step for gRPC streaming query range queries (#4546)" This reverts commit 424274a. * default step if not set Signed-off-by: Joe Elliott <[email protected]> * fix dumping of output to json Signed-off-by: Joe Elliott <[email protected]> * attachExemplars in gRPC diff Signed-off-by: Joe Elliott <[email protected]> * added test and bench Signed-off-by: Joe Elliott <[email protected]> * remove step Signed-off-by: Joe Elliott <[email protected]> * changelog Signed-off-by: Joe Elliott <[email protected]> * fix default step Signed-off-by: Joe Elliott <[email protected]> * lint Signed-off-by: Joe Elliott <[email protected]> * corrected proto import Signed-off-by: Joe Elliott <[email protected]> --------- Signed-off-by: Joe Elliott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Currently the http query range endpoint will choose a default step if none is provided, but the gRPC streaming endpoint will simply return an error:
code = Unknown desc = step required.This PR uses the same logic in the gRPC streaming as http to choose a default step if the passed value is 0.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]